Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean serialized JSON file if exist a format error #93

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

edsonjab
Copy link
Contributor

Fix issues #r74 and #80

@fhdeodato
Copy link

Hey @edsonjab thanks for this

just a question, the cleaned field will be filled with wrong structure once again?

I am not sure why the data was wrong in the first place.

Seems not be so important to load it again since everything is still working without that right?

@edsonjab
Copy link
Contributor Author

Hi @fhdeodato the issue still happens when the app starts if the file has an error trigger the error, but I saw that it happens to much when the app is developing or making local test, so, I think that it doesn't have a big affectation but avoid the error that users report.

Copy link

@fhdeodato fhdeodato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not able to reproduce but the code looks correct and worth of a merge

@MichaelGHSeg MichaelGHSeg merged commit e9c9cc3 into segmentio:main Aug 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants